netdev - Re: [Patch net-next v2] act_mirred: get rid of tcfm_ifindex from struct tcf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171206.145146.1318629799200615292.davem@davemloft.net>
Date:   Wed, 06 Dec 2017 14:51:46 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org, jiri@...lanox.com, jhs@...atatu.com
Subject: Re: [Patch net-next v2] act_mirred: get rid of tcfm_ifindex from
 struct tcf_mirred

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Tue,  5 Dec 2017 16:17:26 -0800

> tcfm_dev always points to the correct netdev and we already
> hold a refcnt, so no need to use tcfm_ifindex to lookup again.
> 
> If we would support moving target netdev across netns, using
> pointer would be better than ifindex.
> 
> This also fixes dumping obsolete ifindex, now after the
> target device is gone we just dump 0 as ifindex.
> 
> Cc: Jiri Pirko <jiri@...lanox.com>
> Cc: Jamal Hadi Salim <jhs@...atatu.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Both act_mirred patches applied, thanks Cong.