netdev - Re: [PATCH net-next] tun: avoid unnecessary READ_ONCE in tun_net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171206.150929.1869136637774624730.davem@davemloft.net>
Date:   Wed, 06 Dec 2017 15:09:29 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     willemdebruijn.kernel@...il.com
Cc:     netdev@...r.kernel.org, jasowang@...hat.com, willemb@...gle.com
Subject: Re: [PATCH net-next] tun: avoid unnecessary READ_ONCE in
 tun_net_xmit

From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Date: Tue,  5 Dec 2017 22:11:17 -0500

> From: Willem de Bruijn <willemb@...gle.com>
> 
> The statement no longer serves a purpose.
> 
> Commit fa35864e0bb7 ("tuntap: Fix for a race in accessing numqueues")
> added the ACCESS_ONCE to avoid a race condition with skb_queue_len.
> 
> Commit 436accebb530 ("tuntap: remove unnecessary sk_receive_queue
> length check during xmit") removed the affected skb_queue_len check.
> 
> Commit 96f84061620c ("tun: add eBPF based queue selection method")
> split the function, reading the field a second time in the callee.
> The temp variable is now only read once, so just remove it.
> 
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Applied, thanks Willem.