netdev - Re: [patch net-next] mlxsw: spectrum: handle NETIF_F_HW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171206.151130.1584808862028101813.davem@davemloft.net>
Date:   Wed, 06 Dec 2017 15:11:30 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, idosch@...lanox.com, mlxsw@...lanox.com
Subject: Re: [patch net-next] mlxsw: spectrum: handle NETIF_F_HW_TC changes
 correctly

From: Jiri Pirko <jiri@...nulli.us>
Date: Wed,  6 Dec 2017 09:41:12 +0100

> From: Jiri Pirko <jiri@...lanox.com>
> 
> Currently, whenever the NETIF_F_HW_TC feature changes, we silently
> always allow it, but we actually do not disable the flows in HW
> on disable. That breaks user's expectations. So just forbid
> the feature disable in case there are any filters offloaded.
> 
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
> Reviewed-by: Ido Schimmel <idosch@...lanox.com>

Applied, thanks Jiri.