netdev - Re: [PATCH v2 3/3] net: macb: change GFP_ATOMIC to GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1712060649060.2460@hadrien>
Date:   Wed, 6 Dec 2017 06:49:18 +0100 (CET)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Julia Cartwright <julia@...com>
cc:     David Miller <davem@...emloft.net>,
        Julia Lawall <julia.lawall@...6.fr>, rafalo@...ence.com,
        nicolas.ferre@...rochip.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kbuild-all@...org
Subject: Re: [PATCH v2 3/3] net: macb: change GFP_ATOMIC to GFP_KERNEL



On Tue, 5 Dec 2017, Julia Cartwright wrote:

> Now that the rx_fs_lock is no longer held across allocation, it's safe
> to use GFP_KERNEL for allocating new entries.
>
> This reverts commit 81da3bf6e3f88 ("net: macb: change GFP_KERNEL to
> GFP_ATOMIC").
>
> Cc: Julia Lawall <julia.lawall@...6.fr>
> Signed-off-by: Julia Cartwright <julia@...com>

Acked-by: Julia Lawall <julia.lawall@...6.fr>


> ---
>  drivers/net/ethernet/cadence/macb_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 758e8b3042b2..234667eaaa92 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -2800,7 +2800,7 @@ static int gem_add_flow_filter(struct net_device *netdev,
>  	int ret = -EINVAL;
>  	bool added = false;
>
> -	newfs = kmalloc(sizeof(*newfs), GFP_ATOMIC);
> +	newfs = kmalloc(sizeof(*newfs), GFP_KERNEL);
>  	if (newfs == NULL)
>  		return -ENOMEM;
>  	memcpy(&newfs->fs, fs, sizeof(newfs->fs));
> --
> 2.14.2
>
>