netdev - Re: [Patch net-next v2] act_mirred: get rid of tcfm_ifindex from struct tcf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171206083348.GA1823@nanopsycho>
Date:   Wed, 6 Dec 2017 09:33:48 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     netdev@...r.kernel.org, Jiri Pirko <jiri@...lanox.com>,
        Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [Patch net-next v2] act_mirred: get rid of tcfm_ifindex from
 struct tcf_mirred

Wed, Dec 06, 2017 at 01:17:26AM CET, xiyou.wangcong@...il.com wrote:
>tcfm_dev always points to the correct netdev and we already
>hold a refcnt, so no need to use tcfm_ifindex to lookup again.
>
>If we would support moving target netdev across netns, using
>pointer would be better than ifindex.
>
>This also fixes dumping obsolete ifindex, now after the
>target device is gone we just dump 0 as ifindex.
>
>Cc: Jiri Pirko <jiri@...lanox.com>
>Cc: Jamal Hadi Salim <jhs@...atatu.com>
>Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>

Thanks!