lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 6 Dec 2017 11:17:22 +0100 From: Peter Zijlstra <peterz@...radead.org> To: Song Liu <songliubraving@...com> Cc: rostedt@...dmis.org, mingo@...hat.com, davem@...emloft.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, daniel@...earbox.net, kernel-team@...com Subject: Re: [PATCH v4 1/6] perf: prepare perf_event.h for new types perf_kprobe and perf_uprobe On Mon, Dec 04, 2017 at 05:27:24PM -0800, Song Liu wrote: > diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h > index 362493a..0f39b31 100644 > --- a/include/uapi/linux/perf_event.h > +++ b/include/uapi/linux/perf_event.h > @@ -291,6 +291,16 @@ enum perf_event_read_format { > PERF_FORMAT_MAX = 1U << 4, /* non-ABI */ > }; > > +/* > + * Flags in config, used by dynamic PMU kprobe and uprobe > + * > + * PERF_PROBE_CONFIG_IS_RETPROBE if set, create kretprobe/uretprobe > + * if not set, create kprobe/uprobe > + */ > +enum perf_probe_config { > + PERF_PROBE_CONFIG_IS_RETPROBE = 1U << 0, /* [k,u]retprobe */ > +}; This should not be in uapi; pmu's can describe their config format in sysfs. PMU_FORMAT_ATTR(retprobe, "config:0"); static struct attribute *kprobe_attr[] = { &format_attr_retprobe, NULL, }; static struct attribute_group kprobe_format_group = { .name = "format", .attrs = kprobe_attrs, }; static const struct attribute_group *kprobe_attr_groups[] = { &kprobe_format_group, NULL, }; struct pmu perf_kprobe { ... .attr_groups = kprobe_attr_groups, }; Other than that, this series looks good to me. Thanks!
Powered by blists - more mailing lists