netdev - Re: [PATCH net-next 1/6] net: sched: sch_api: handle generic qdisc errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171207.130815.2195718476285159124.davem@davemloft.net>
Date:   Thu, 07 Dec 2017 13:08:15 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...il.com
Cc:     jhs@...atatu.com, aring@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us, netdev@...r.kernel.org, kernel@...atatu.com
Subject: Re: [PATCH net-next 1/6] net: sched: sch_api: handle generic qdisc
 errors

From: David Ahern <dsahern@...il.com>
Date: Thu, 7 Dec 2017 10:52:01 -0700

> What value are the messages providing above and beyond the standard libc
> strerror(errno)? In the case of ENOMEM, there is nothing in the user can
> do to fix that particular command, so why bloat the code with extraneous
> messages? Similarly with other errors like ENODEV -- if there is only 1
> device in question AND the user specified the device then you do not
> need to augment with an additional error message.

Agreed, all of this stuff is bloat and not useful in any way to the user.