netdev - Re: [PATCH net-next] netdevsim: check return value of debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171206220526.04e1bfea@cakuba.netronome.com>
Date:   Wed, 6 Dec 2017 22:05:26 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     "Prashant Bhole" <bhole_prashant_q7@....ntt.co.jp>
Cc:     "'David S . Miller'" <davem@...emloft.net>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] netdevsim: check return value of
 debugfs_create_dir

On Thu, 7 Dec 2017 13:10:39 +0900, Prashant Bhole wrote:
> > From: Jakub Kicinski [mailto:jakub.kicinski@...ronome.com]
> > 
> > On Thu,  7 Dec 2017 10:02:13 +0900, Prashant Bhole wrote:  
> > > - Handled debugfs_create_dir failure in nsim_init()
> > > - Fixed return value of nsim_module_init() when debugfs_create_dir
> > > fails
> > >
> > > Signed-off-by: Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>  
> > 
> > Why?  Failing to expose the state via DebugFS is not fatal to the driver.  
> 
> Ok, my intention was to handle the return code properly, which is not needed
> as per your comment.
> Shall I remove the existing handling in nsim_module_init() in separate
> patch? 

I was going back and forth on the error handling quite a bit writing
that code.  In the end I decided to leave the module_init check and
check for bpf prog directory.  Former one is mostly useful to make sure
the is no duplicate directory with the same name, the latter to limit
possible false positive in the selftest..

> Because it will prevent netdevsim from loading when debugfs is disabled.

Note that netdevsim depends on DEBUG_FS:

config NETDEVSIM
	tristate "Simulated networking device"
	depends on DEBUG_FS