lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 7 Dec 2017 06:07:49 -0500 From: Neil Horman <nhorman@...driver.com> To: Xin Long <lucien.xin@...il.com> Cc: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>, network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org, davem <davem@...emloft.net> Subject: Re: [PATCH net-next 00/12] sctp: Implement Stream Interleave: The I-DATA Chunk Supporting User Message Interleaving On Wed, Dec 06, 2017 at 10:20:01AM -0500, Neil Horman wrote: > On Wed, Dec 06, 2017 at 11:21:46AM +0800, Xin Long wrote: > > On Wed, Dec 6, 2017 at 1:30 AM, Marcelo Ricardo Leitner > > <marcelo.leitner@...il.com> wrote: > > > On Tue, Dec 05, 2017 at 11:15:57PM +0800, Xin Long wrote: > > >> Stream Interleave would be Implemented in two Parts: > > >> 1. The I-DATA Chunk Supporting User Message Interleaving > > >> 2. Interaction with Other SCTP Extensions > > >> > > > > > > I have reviewed this patchset a couple of times already before the > > > posting and other than the missing blank line (heh), it looks good to > > > me. Would ack it now but we'll need a respin for the newline. > > OK, thanks ! > > > > > > > > Xin, please wait a bit before respining it. Maybe Neil and others have > > > more comments on it. > > Sure, > > > > I added the part 2 (Interaction with Other SCTP Extensions) only > > as an attachment here, so that it would be more clear to know the > > big picture by checking it. (patchset_2.tar.gz) > > > > > > I also added the test cases here I've done, based on sctp-tests > > (conformance.tar.gz). It includes: > > idata with ulp layer process > > idata with stream reconfig > > idata with stream scheduler > > idata with sctp prsctp > > idata with auth > > > > (idata with sctp-tests others old tests) > > > > and note that another file (debug.tar.gz) is some patches for sctp > > to make these tests easier to be done. > > > > Thanks, I'll look at this shortly > Neil > > Given the follow on patchset, I think this all looks pretty good. For the series Acked-by: Neil Horman <nhorman@...driver.com>
Powered by blists - more mailing lists