netdev - Re: [PATCH net-next V2] tuntap: fix possible deadlock when fail to register netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171208.104449.1637984942527300904.davem@davemloft.net>
Date:   Fri, 08 Dec 2017 10:44:49 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     mst@...hat.com
Cc:     jasowang@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, eric.dumazet@...il.com,
        willemb@...gle.com
Subject: Re: [PATCH net-next V2] tuntap: fix possible deadlock when fail to
 register netdev

From: "Michael S. Tsirkin" <mst@...hat.com>
Date: Fri, 8 Dec 2017 06:43:44 +0200

> On Fri, Dec 08, 2017 at 12:02:30PM +0800, Jason Wang wrote:
>> Private destructor could be called when register_netdev() fail with
>> rtnl lock held. This will lead deadlock in tun_free_netdev() who tries
>> to hold rtnl_lock. Fixing this by switching to use spinlock to
>> synchronize.
>> 
>> Fixes: 96f84061620c ("tun: add eBPF based queue selection method")
>> Reported-by: Eric Dumazet <eric.dumazet@...il.com>
>> Cc: Eric Dumazet <eric.dumazet@...il.com>
>> Cc: Willem de Bruijn <willemb@...gle.com>
>> Signed-off-by: Jason Wang <jasowang@...hat.com>
> 
> Acked-by: Michael S. Tsirkin <mst@...hat.com>

Applied, thanks.