netdev - Re: [PATCH net-next 1/1] forcedeth: remove unnecessary variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 8 Dec 2017 10:11:08 +0800
From:   Yanjun Zhu <yanjun.zhu@...cle.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, keescook@...omium.org
Subject: Re: [PATCH net-next 1/1] forcedeth: remove unnecessary variable



On 2017/12/8 3:07, David Miller wrote:
> From: Zhu Yanjun <yanjun.zhu@...cle.com>
> Date: Wed,  6 Dec 2017 23:15:15 -0500
>
>> Since both tx_ring and first_tx are the head of tx ring, it not
>> necessary to use two variables. So first_tx is removed.
> These are not variables, they are structure members.
Sure. These 2 structure members are the head of tx ring. And they are 
not changed in
the whole driver. So they are duplicate.

I will change to structure members and send V2.

Zhu Yanjun
>