netdev - Re: [PATCH] bnxt_en: Fix sources of spurious netpoll warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171208.140830.1542476063382857622.davem@davemloft.net>
Date:   Fri, 08 Dec 2017 14:08:30 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     michael.chan@...adcom.com
Cc:     calvinowens@...com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-team@...com
Subject: Re: [PATCH] bnxt_en: Fix sources of spurious netpoll warnings

From: Michael Chan <michael.chan@...adcom.com>
Date: Fri, 8 Dec 2017 09:35:42 -0800

> On Fri, Dec 8, 2017 at 9:05 AM, Calvin Owens <calvinowens@...com> wrote:
>> After applying 2270bc5da3497945 ("bnxt_en: Fix netpoll handling") and
>> 903649e718f80da2 ("bnxt_en: Improve -ENOMEM logic in NAPI poll loop."),
>> we still see the following WARN fire:
 ...
>> This happens because we increment rx_pkts on -ENOMEM and -EIO, resulting
>> in rx_pkts > 0. Fix this by only bumping rx_pkts if we were actually
>> given a non-zero budget.
>>
>> Signed-off-by: Calvin Owens <calvinowens@...com>
> 
> Thanks.
> Acked-by: Michael Chan <michael.chan@...adcom.com>

Applied and queued up for -stable.