netdev - Re: [PATCH net-next] ip6_vti: adjust vti mtu according to mtu of output device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ddbb8243-4eed-1c74-e520-d705727e0d37@oracle.com>
Date:   Fri, 8 Dec 2017 15:25:07 -0800
From:   Shannon Nelson <shannon.nelson@...cle.com>
To:     Alexey Kodanev <alexey.kodanev@...cle.com>,
        Steffen Klassert <steffen.klassert@...unet.com>
Cc:     netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
        Petr Vorel <pvorel@...e.cz>
Subject: Re: [PATCH net-next] ip6_vti: adjust vti mtu according to mtu of
 output device

On 12/8/2017 3:54 AM, Alexey Kodanev wrote:
> On 12/08/2017 10:02 AM, Steffen Klassert wrote:
>> On Wed, Dec 06, 2017 at 07:38:19PM +0300, Alexey Kodanev wrote:

Since you're planning to do a 2nd version anyway, can we get a couple of 
the commit message issues cleaned up?

>>> LTP/udp6_ipsec_vti tests fail when sending large UDP datagrams
>>> that require fragmentation and underlying device MTU <= 1500.

s/underlying device/the underlying device has/

>>> This happens because ip6_vti sets mtu to ETH_DATA_LEN and not
>>> updating it depending on a destiantion address.

s/destiantion/destination/

>>>
>>> Futhure attempts to send UDP packets may succeed because pmtu

s/Futhure/Further/

>>> get updated on ICMPV6_PKT_TOOBIG in vti6_err().

s/get/gets/

>>>
>>> Here is the example when output device MTU set to 9000:

s/output device MTU/the output device MTU is/

Thanks,
sln