netdev - Re: [PATCH V2 net-next 2/8] net: hns3: Add mailbox support to VF driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 9 Dec 2017 01:16:44 +0100
From:   Philippe Ombredanne <pombredanne@...b.com>
To:     Salil Mehta <salil.mehta@...wei.com>
Cc:     "David S. Miller" <davem@...emloft.net>, yisen.zhuang@...wei.com,
        lipeng321@...wei.com, mehta.salil.lnk@...il.com,
        netdev@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        linux-rdma@...r.kernel.org, linuxarm@...wei.com
Subject: Re: [PATCH V2 net-next 2/8] net: hns3: Add mailbox support to VF driver

Sali,

On Fri, Dec 8, 2017 at 10:16 PM, Salil Mehta <salil.mehta@...wei.com> wrote:
> This patch adds the support of the mailbox to the VF driver. The
> mailbox shall be used as an interface to communicate with the
> PF driver for various purposes like {set|get} MAC related
> operations, reset, link status etc. The mailbox supports both
> synchronous and asynchronous command send to PF driver.
>
> Signed-off-by: Salil Mehta <salil.mehta@...wei.com>
> Signed-off-by: lipeng <lipeng321@...wei.com>
[...]
> --- /dev/null
> +++ b/drivers/net/ethernet/hisilicon/hns3/hclge_mbx.h
> @@ -0,0 +1,94 @@
> +/*
> + * Copyright (c) 2016-2017 Hisilicon Limited.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + */

Why not use the new SPDX ids?
e.g.
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +/* Copyright (c) 2016-2017 Hisilicon Limited. */

See Linus posts and Thomas doc patches for details.

-- 
Cordially
Philippe Ombredanne