netdev - Re: [PATCH net-next 2/2] veth: set peer GSO values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171209195112.GA17500@ssarabia-MOBL7.amr.corp.intel.com>
Date:   Sat, 9 Dec 2017 11:51:13 -0800
From:   Solio Sarabia <solio.sarabia@...el.com>
To:     David Ahern <dsahern@...il.com>
Cc:     netdev@...r.kernel.org, sthemmin@...rosoft.com,
        stephen@...workplumber.org, davem@...emloft.net
Subject: Re: [PATCH net-next 2/2] veth: set peer GSO values

On Sat, Dec 09, 2017 at 09:41:25AM -0700, David Ahern wrote:
> On 12/7/17 4:40 PM, Stephen Hemminger wrote:
> > diff --git a/drivers/net/veth.c b/drivers/net/veth.c
> > index f5438d0978ca..a69ad39ee57e 100644
> > --- a/drivers/net/veth.c
> > +++ b/drivers/net/veth.c
> > @@ -410,6 +410,9 @@ static int veth_newlink(struct net *src_net, struct net_device *dev,
> >  	if (ifmp && (dev->ifindex != 0))
> >  		peer->ifindex = ifmp->ifi_index;
> >  
> > +	peer->gso_max_size = dev->gso_max_size;
> > +	peer->gso_max_segs = dev->gso_max_segs;
> > +
> >  	err = register_netdevice(peer);
> >  	put_net(net);
> >  	net = NULL;
> > 
> 
> What if gso changes are made after device create? They are not
> propagated to the peer device like they are on link create.

This would be a nice addition after ongoing patches are merged,
since veth usually lives in another netns. For docker, it requires
a couple of extra commands to expose the peer's netns.