netdev - Re: [PATCH net-next] veth: fix setting peer gso values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171210011627.GA9224@ssarabia-MOBL7.amr.corp.intel.com>
Date:   Sat, 9 Dec 2017 17:16:28 -0800
From:   Solio Sarabia <solio.sarabia@...el.com>
To:     davem@...emloft.net, stephen@...workplumber.org
Cc:     netdev@...r.kernel.org, sthemmin@...rosoft.com,
        shiny.sebastian@...el.com, solio.sarabia@...el.com
Subject: Re: [PATCH net-next] veth: fix setting peer gso values

On Sat, Dec 09, 2017 at 11:11:33AM -0800, Solio Sarabia wrote:
> GSO values are not correctly set for peer and dev. When creating
> the veth link, GSO attributes are set for peer device, propagate
> these values from peer to dev.
> 
> Signed-off-by: Solio Sarabia <solio.sarabia@...el.com>
> ---
>  drivers/net/veth.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/veth.c b/drivers/net/veth.c
> index a69ad39..d936c8a 100644
> --- a/drivers/net/veth.c
> +++ b/drivers/net/veth.c
> @@ -410,8 +410,8 @@ static int veth_newlink(struct net *src_net, struct net_device *dev,
>  	if (ifmp && (dev->ifindex != 0))
>  		peer->ifindex = ifmp->ifi_index;
>  
> -	peer->gso_max_size = dev->gso_max_size;
> -	peer->gso_max_segs = dev->gso_max_segs;
> +	dev->gso_max_size = peer->gso_max_size;
> +	dev->gso_max_segs = peer->gso_max_segs;

Seems this patch won't be necessary after all. Parameter order in
iproute2 util will be changed to set GSO on first dev device (not
on the peer), making current code right: cloning from dev to peer.

>  
>  	err = register_netdevice(peer);
>  	put_net(net);
> -- 
> 2.7.4
>