netdev - Re: [PATCH] net: ipv4: fix for a race condition in raw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1512880255.25033.36.camel@gmail.com>
Date:   Sat, 09 Dec 2017 20:30:55 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     simo.ghannam@...il.com, netdev@...r.kernel.org
Cc:     Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH] net: ipv4: fix for a race condition in raw_sendmsg

On Sun, 2017-12-10 at 03:50 +0000, simo.ghannam@...il.com wrote:
> From: Mohamed Ghannam <simo.ghannam@...il.com>
> 
> inet->hdrincl is racy, and could lead to uninitialized stack pointer
> usage, so its value should be read only once.
> 
> Signed-off-by: Mohamed Ghannam <simo.ghannam@...il.com>
> ---
>  net/ipv4/raw.c | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)

Thanks a lot for fixing this very serious bug.

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Please David add :

Fixes: c008ba5bdc9f ("ipv4: Avoid reading user iov twice after raw_probe_proto_opt")

Thanks !