netdev - Re: [PATCH net v2 8/9] net: aquantia: Fix typo in ethtool statistics names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171211.105103.905385732602210885.davem@davemloft.net>
Date:   Mon, 11 Dec 2017 10:51:03 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     andrew@...n.ch
Cc:     igor.russkikh@...antia.com, netdev@...r.kernel.org,
        darcari@...hat.com, pavel.belous@...antia.com,
        Nadezhda.Krupnina@...antia.com, simon.edelhaus@...antia.com
Subject: Re: [PATCH net v2 8/9] net: aquantia: Fix typo in ethtool
 statistics names

From: Andrew Lunn <andrew@...n.ch>
Date: Mon, 11 Dec 2017 16:45:06 +0100

> I know it is not nice, but maybe we need to consider this is part of
> the kernel ABI? You could be breaking applications by making this
> change.
> 
> What do others think?

Not really.

The whole reason we have a string array exposed to userspace is so that
tools absolutely cannot hard code the driver specific ethtool stats
in any way shape or form, and must always query the number, order,
and names every single time.