netdev - Re: [PATCH next] ipvlan: add L2 check for packets arriving via virtual devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171211.111523.656092715140972680.davem@davemloft.net>
Date:   Mon, 11 Dec 2017 11:15:23 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     mahesh@...dewar.net
Cc:     netdev@...r.kernel.org, edumazet@...gle.com,
        amit.sikka@...csson.com, maheshb@...gle.com
Subject: Re: [PATCH next] ipvlan: add L2 check for packets arriving via
 virtual devices

From: Mahesh Bandewar <mahesh@...dewar.net>
Date: Thu,  7 Dec 2017 15:15:43 -0800

> From: Mahesh Bandewar <maheshb@...gle.com>
> 
> Packets that don't have dest mac as the mac of the master device should
> not be entertained by the IPvlan rx-handler. This is mostly true as the
> packet path mostly takes care of that, except when the master device is
> a virtual device. As demonstrated in the following case -
 ...
> This patch adds that missing check in the IPvlan rx-handler.
> 
> Reported-by: Amit Sikka <amit.sikka@...csson.com>
> Signed-off-by: Mahesh Bandewar <maheshb@...gle.com>

Applied, but it's a shame that the data plane takes on this new MAC
compare operation.