lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20171211.140429.1510398539345216417.davem@davemloft.net>
Date:   Mon, 11 Dec 2017 14:04:29 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     yanjun.zhu@...cle.com
Cc:     netdev@...r.kernel.org, keescook@...omium.org
Subject: Re: [PATCHv2 net-next 1/1] forcedeth: remove unnecessary structure
 member

From: Zhu Yanjun <yanjun.zhu@...cle.com>
Date: Sat,  9 Dec 2017 22:07:26 -0500

> Since both tx_ring and first_tx are the head of tx ring, it not
> necessary to use two structure members to statically indicate
> the head of tx ring. So first_tx is removed.
> 
> CC: Srinivas Eeda <srinivas.eeda@...cle.com>
> CC: Joe Jin <joe.jin@...cle.com>
> CC: Junxiao Bi <junxiao.bi@...cle.com>
> Signed-off-by: Zhu Yanjun <yanjun.zhu@...cle.com>

I suspect this extraneous member was meant to be used for multiqueue
support or something like that.

But, it never got really used, and your change is correct.

Applied, thanks.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ