netdev - Re: [PATCH net] fou: fix some member types in guehdr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171211.141020.2190669621502949227.davem@davemloft.net>
Date:   Mon, 11 Dec 2017 14:10:20 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, therbert@...gle.com
Subject: Re: [PATCH net] fou: fix some member types in guehdr

From: Xin Long <lucien.xin@...il.com>
Date: Sun, 10 Dec 2017 16:56:00 +0800

> guehdr struct is used to build or parse gue packets, which
> are always in big endian. It's better to define all guehdr
> members as __beXX types.
> 
> Also, in validate_gue_flags it's not good to use a __be32
> variable for both Standard flags(__be16) and Private flags
> (__be32), and pass it to other funcions.
> 
> This patch could fix a bunch of sparse warnings from fou.
> 
> Fixes: 5024c33ac354 ("gue: Add infrastructure for flags and options")
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Looks good, applied, thanks.