netdev - Re: [PATCH net-next 2/2 v8] net: ethernet: Add a driver for Gemini gigabit ethernet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Dec 2017 14:16:51 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     linus.walleij@...aro.org
Cc:     netdev@...r.kernel.org, mirq-linux@...e.qmqm.pl,
        janos.dev@...il.com, paulius.zaleckas@...il.com,
        linux-arm-kernel@...ts.infradead.org, ulli.kroll@...glemail.com,
        f.fainelli@...il.com, tobias.waldvogel@...il.com
Subject: Re: [PATCH net-next 2/2 v8] net: ethernet: Add a driver for Gemini
 gigabit ethernet

From: Linus Walleij <linus.walleij@...aro.org>
Date: Sun, 10 Dec 2017 23:45:58 +0100

> diff --git a/drivers/net/ethernet/cortina/Kconfig b/drivers/net/ethernet/cortina/Kconfig
> new file mode 100644
> index 000000000000..7d279ac4357d
> --- /dev/null
> +++ b/drivers/net/ethernet/cortina/Kconfig
> @@ -0,0 +1,24 @@
> +# SPDX-License-Identifier: GPL-2.0
> +# Cortina ethernet devices
> +
> +config NET_VENDOR_CORTINA
> +	bool "Cortina Gemini devices"
> +	depends on (ARM || COMPILE_TEST)
> +	default ARCH_GEMINI
> +	---help---
> +	  If you have a network (Ethernet) card belonging to this class, say Y
> +	  and read the Ethernet-HOWTO, available from
> +	  <http://www.tldp.org/docs.html#howto>.

Vendor Kconfig guards should default to 'y'.  Remove the depends guard.

> +
> +if NET_VENDOR_CORTINA
> +
> +config GEMINI_ETHERNET
> +	tristate "Gemini Gigabit Ethernet support"
> +	depends on ARCH_GEMINI
> +	depends on OF
> +	select PHYLIB
> +	select CRC32
> +	---help---
> +	  This driver supports StorLink SL351x (Gemini) dual Gigabit Ethernet.

Make this driver buildable anywhere, you don't use any platform architecture
specific features.

Otherwise your driver will have bad build coverage and will likely
stop building when core APIs are changed.