netdev - RE: [PATCH] dt-bindings: fec: Make the phy-reset-gpio polarity explicit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Dec 2017 01:19:40 +0000
From:   Andy Duan <fugang.duan@....com>
To:     Fabio Estevam <festevam@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Fabio Estevam <fabio.estevam@....com>
Subject: RE: [PATCH] dt-bindings: fec: Make the phy-reset-gpio polarity
 explicit

From: Fabio Estevam <festevam@...il.com> Sent: Friday, December 08, 2017 10:12 PM
>The GPIO polarity passed to phy-reset-gpio is ignored by the FEC driver and it
>is assumed to be active low.
>
>It can be active high only when the 'phy-reset-active-high' property is present.
>
>The current examples pass active high polarity and work fine, but in order to
>improve the documentation make it explicit what the real polarity is.
>
>Signed-off-by: Fabio Estevam <fabio.estevam@....com>

Since driver don't take care the flag, it doesn't matter what the value for the gpio polarity flag.
But the change look like explicit for user. 

Acked-by: Fugang Duan <fugang.duan@....com>

>---
> Documentation/devicetree/bindings/net/fsl-fec.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt
>b/Documentation/devicetree/bindings/net/fsl-fec.txt
>index f0dc944..2d41fb9 100644
>--- a/Documentation/devicetree/bindings/net/fsl-fec.txt
>+++ b/Documentation/devicetree/bindings/net/fsl-fec.txt
>@@ -59,7 +59,7 @@ ethernet@...ec000 {
> 	reg = <0x83fec000 0x4000>;
> 	interrupts = <87>;
> 	phy-mode = "mii";
>-	phy-reset-gpios = <&gpio2 14 0>; /* GPIO2_14 */
>+	phy-reset-gpios = <&gpio2 14 GPIO_ACTIVE_LOW>; /* GPIO2_14 */
> 	local-mac-address = [00 04 9F 01 1B B9];
> 	phy-supply = <&reg_fec_supply>;
> };
>@@ -71,7 +71,7 @@ ethernet@...ec000 {
> 	reg = <0x83fec000 0x4000>;
> 	interrupts = <87>;
> 	phy-mode = "mii";
>-	phy-reset-gpios = <&gpio2 14 0>; /* GPIO2_14 */
>+	phy-reset-gpios = <&gpio2 14 GPIO_ACTIVE_LOW>; /* GPIO2_14 */
> 	local-mac-address = [00 04 9F 01 1B B9];
> 	phy-supply = <&reg_fec_supply>;
> 	phy-handle = <&ethphy>;
>--
>2.7.4