netdev - RE: [PATCH] Fix handling of verdicts after NF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Dec 2017 00:36:35 +0000
From:   "Banerjee, Debabrata" <dbanerje@...mai.com>
To:     'Pablo Neira Ayuso' <pablo@...filter.org>
CC:     "David S . Miller" <davem@...emloft.net>,
        "netfilter-devel@...r.kernel.org" <netfilter-devel@...r.kernel.org>,
        "coreteam@...filter.org" <coreteam@...filter.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH] Fix handling of verdicts after NF_QUEUE

> From: Pablo Neira Ayuso [mailto:pablo@...filter.org]
> On Mon, Dec 11, 2017 at 06:30:24PM -0500, Debabrata Banerjee wrote:
> > +	} else {
> > +		/* Implicit handling for NF_STOLEN, as well as any other
> > +		 * non conventional verdicts.
> > +		 */
> > +		ret = 0;
> 
> Another possibility (more simple?) would be this:
> 
> int nf_hook_slow(struct sk_buff *skb, struct nf_hook_state *state) {
>         struct nf_hook_entry *entry;
>         unsigned int verdict;
> -       int ret = 0;
> +       int ret;
> 
>         entry = rcu_dereference(state->hook_entries);
> next_hook:
> +       ret = 0;
> 
> Basically, make sure ret is set to zero when jumping to the next_hook label.

Many ways to fix it, but I thought including the comment was appropriate.
Happy to change it if we want simpler instead.

-Deb