netdev - Re: [PATCHv2 2/3] net: socionext: Add Synquacer NetSec driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABb+yY2VoKs_6CarHjf=_B9vQH06nh+D=RYbvRpvX_x=6RiM-A@mail.gmail.com>
Date:   Wed, 13 Dec 2017 21:16:24 +0530
From:   Jassi Brar <jassisinghbrar@...il.com>
To:     Ard Biesheuvel <ard.biesheuvel@...aro.org>
Cc:     "<netdev@...r.kernel.org>" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Arnd Bergmann <arnd.bergmann@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Jassi Brar <jaswinder.singh@...aro.org>
Subject: Re: [PATCHv2 2/3] net: socionext: Add Synquacer NetSec driver

On Tue, Dec 12, 2017 at 10:54 PM, Ard Biesheuvel
<ard.biesheuvel@...aro.org> wrote:
> On 12 December 2017 at 17:15,  <jassisinghbrar@...il.com> wrote:
....
>> +
>> +static int netsec_netdev_load_microcode(struct netsec_priv *priv)
>> +{
>> +       int err;
>> +
>> +       err = netsec_netdev_load_ucode_region(
>> +               priv, NETSEC_REG_DMAC_HM_CMD_BUF,
>> +               le32_to_cpup(priv->eeprom_base + NETSEC_EEPROM_HM_ME_ADDRESS_H),
>> +               le32_to_cpup(priv->eeprom_base + NETSEC_EEPROM_HM_ME_ADDRESS_L),
>> +               le32_to_cpup(priv->eeprom_base + NETSEC_EEPROM_HM_ME_SIZE));
>
> ... here, and in other places below, you are still dereferencing
> eeprom_base as if it is a pointer, which is not allowed with in the
> __iomem address space. This should use readl() instead [which happens
> to incorporate the endian swap as well]
>
Ahh, how could it have been just two revisions!

thanks