netdev - Re: [PATCH net 2/3] net/mlx4_core: Fix wrong calculation of free counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5b37897e-bd24-40dc-8082-3c3b546764e1@mellanox.com>
Date:   Wed, 13 Dec 2017 18:07:30 +0200
From:   Tariq Toukan <tariqt@...lanox.com>
To:     Tariq Toukan <tariqt@...lanox.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, Eran Ben Elisha <eranbe@...lanox.com>
Subject: Re: [PATCH net 2/3] net/mlx4_core: Fix wrong calculation of free
 counters



On 13/12/2017 10:30 AM, Tariq Toukan wrote:
> From: Eran Ben Elisha <eranbe@...lanox.com>
> 
> The field res_free indicates the total number of counters which are free
> to allocation (reserved and unreserved). Fix a bug of reducing the
> reserved counters from this field before allocation.
> 
> Due to this bug, free counters which are not reserved couldn't be
> allocated, fixed it.
> 
> Fixes: 9de92c60beaa ("net/mlx4_core: Adjust counter grant policy in the resource tracker")
> Signed-off-by: Eran Ben Elisha <eranbe@...lanox.com>
> Signed-off-by: Tariq Toukan <tariqt@...lanox.com>

I forgot to mention a reviewer for this patch, and would edit the commit 
message as well.

I'll send a re-spin shortly.

> ---
>   drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
> index 04304dd894c6..606a0e0beeae 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
> @@ -611,7 +611,6 @@ int mlx4_init_resource_tracker(struct mlx4_dev *dev)
>   						MLX4_MAX_PORTS;
>   				else
>   					res_alloc->guaranteed[t] = 0;
> -				res_alloc->res_free -= res_alloc->guaranteed[t];
>   				break;
>   			default:
>   				break;
>