netdev - Re: [PATCH] hippi: Fix a Fix a possible sleep-in-atomic bug in rr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171213.145319.1650448955612362760.davem@davemloft.net>
Date:   Wed, 13 Dec 2017 14:53:19 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     baijiaju1990@....com
Cc:     jes@...ined-monkey.org, jes@...dopensource.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hippi: Fix a Fix a possible sleep-in-atomic bug in
 rr_close

From: Jia-Ju Bai <baijiaju1990@....com>
Date: Tue, 12 Dec 2017 16:49:52 +0800

> The driver may sleep under a spinlock.
> The function call path is:
> rr_close (acquire the spinlock)
>   free_irq --> may sleep
> 
> To fix it, free_irq is moved to the place without holding the spinlock.
> 
> This bug is found by my static analysis tool(DSAC) and checked by my code review.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@....com>

Applied.