netdev - Re: [PATCH net-next] net: avoid skb_warn_bad_offload on IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171213.151437.1672477404352103776.davem@davemloft.net>
Date:   Wed, 13 Dec 2017 15:14:37 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     willemdebruijn.kernel@...il.com
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, willemb@...gle.com
Subject: Re: [PATCH net-next] net: avoid skb_warn_bad_offload on IS_ERR

From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Date: Tue, 12 Dec 2017 11:39:04 -0500

> From: Willem de Bruijn <willemb@...gle.com>
> 
> skb_warn_bad_offload warns when packets enter the GSO stack that
> require skb_checksum_help or vice versa. Do not warn on arbitrary
> bad packets. Packet sockets can craft many. Syzkaller was able to
> demonstrate another one with eth_type games.
> 
> In particular, suppress the warning when segmentation returns an
> error, which is for reasons other than checksum offload.
> 
> See also commit 36c92474498a ("net: WARN if skb_checksum_help() is
> called on skb requiring segmentation") for context on this warning.
> 
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Applied, thanks Willem.