netdev - Re: [PATCH] net: phy: marvell: avoid pause mode on SGMII-to-Copper for 88e151x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171213.161423.1305694719573286723.davem@davemloft.net>
Date:   Wed, 13 Dec 2017 16:14:23 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     rmk+kernel@...linux.org.uk
Cc:     andrew@...n.ch, f.fainelli@...il.com, jon@...id-run.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH] net: phy: marvell: avoid pause mode on SGMII-to-Copper
 for 88e151x

From: Russell King <rmk+kernel@...linux.org.uk>
Date: Wed, 13 Dec 2017 09:22:09 +0000

> @@ -924,6 +924,16 @@ static int m88e1510_config_init(struct phy_device *phydev)
>  		err = marvell_set_page(phydev, MII_MARVELL_COPPER_PAGE);
>  		if (err < 0)
>  			return err;
> +
> +		/* There appears to be a bug in the 88e1512 when used in
> +		 * SGMII to copper mode, where the AN advertisment register
> +		 * clears the pause bits each time a negotiation occurs.
> +		 * This means we can never be truely sure what was advertised,
> +		 * so disable Pause support.
> +		 */
> +		pause = SUPPORTED_Pause | SUPPORTED_Asym_Pause;
> +		phydev->supported &= ~pause;
> +		phydev->advertising &= ~pause;
>  	}
>  

This function doesn't have a local 'pause' variable in any of my trees.

I wonder what you generated this against, and even more importantly, what
tree the reviewers were considering when looking at this patch :)