netdev - Re: [PATCH 2/5] VSOCK: extract connect/accept functions from vsock_diag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171213.163258.1602423154155241312.davem@davemloft.net>
Date:   Wed, 13 Dec 2017 16:32:58 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     stefanha@...hat.com
Cc:     netdev@...r.kernel.org, jhansen@...are.com, decui@...rosoft.com
Subject: Re: [PATCH 2/5] VSOCK: extract connect/accept functions from
 vsock_diag_test.c

From: Stefan Hajnoczi <stefanha@...hat.com>
Date: Wed, 13 Dec 2017 14:49:08 +0000

> +#include <sys/socket.h>
> +#include "../../../include/uapi/linux/vm_sockets.h"
> +
 ...
> -#include "../../../include/uapi/linux/vm_sockets.h"
>  #include "../../../include/uapi/linux/vm_sockets_diag.h"

This really should never be necessary.

As part of the build, before tunning tests, one is required to do
"make headers_install" and whether as root or a normal user, this
will make the UAPI headers of the current kernel available to the
build of the testcases.

So please undo this weird relative include stuff.

Thanks.