netdev - Re: [PATCH net-next v2] bpf/tracing: fix kernel/events/core.c compilation error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a37933bb-bb0e-2df5-b724-e8b8c36a5621@iogearbox.net>
Date:   Wed, 13 Dec 2017 22:51:56 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Yonghong Song <yhs@...com>, ast@...com, sfr@...b.auug.org.au,
        netdev@...r.kernel.org
Cc:     kernel-team@...com
Subject: Re: [PATCH net-next v2] bpf/tracing: fix kernel/events/core.c
 compilation error

On 12/13/2017 07:35 PM, Yonghong Song wrote:
> Commit f371b304f12e ("bpf/tracing: allow user space to
> query prog array on the same tp") introduced a perf
> ioctl command to query prog array attached to the
> same perf tracepoint. The commit introduced a
> compilation error under certain config conditions, e.g.,
>   (1). CONFIG_BPF_SYSCALL is not defined, or
>   (2). CONFIG_TRACING is defined but neither CONFIG_UPROBE_EVENTS
>        nor CONFIG_KPROBE_EVENTS is defined.
> 
> Error message:
>   kernel/events/core.o: In function `perf_ioctl':
>   core.c:(.text+0x98c4): undefined reference to `bpf_event_query_prog_array'
> 
> This patch fixed this error by guarding the real definition under
> CONFIG_BPF_EVENTS and provided static inline dummy function
> if CONFIG_BPF_EVENTS was not defined.
> It renamed the function from bpf_event_query_prog_array to
> perf_event_query_prog_array and moved the definition from linux/bpf.h
> to linux/trace_events.h so the definition is in proximity to
> other prog_array related functions.
> 
> Fixes: f371b304f12e ("bpf/tracing: allow user space to query prog array on the same tp")
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Yonghong Song <yhs@...com>

That's better, applied to bpf-next, thanks Yonghong!