netdev - Re: [PATCH v3 iproute2 net-next] gre6: add collect metadata support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALDO+SYKSv5fU=bwtCpFK_2VoJJ2k9+pb0RhLdOVcYw-9nD2kw@mail.gmail.com>
Date:   Tue, 12 Dec 2017 17:43:07 -0800
From:   William Tu <u9012063@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Daniel Borkmann <daniel@...earbox.net>
Subject: Re: [PATCH v3 iproute2 net-next] gre6: add collect metadata support

On Tue, Dec 12, 2017 at 5:40 PM, Stephen Hemminger
<stephen@...workplumber.org> wrote:
> On Tue, 12 Dec 2017 17:07:23 -0800
> William Tu <u9012063@...il.com> wrote:
>
>> +.RB external
>> +- make this tunnel externally controlled (or not, which is the default).
>> +This is also known as collect_metadata mode for tunnels.
>
> Much better.
> The man page still needs some work.
>
> The phrase "is also known as" is a little confusing and putting a specific
> variable name in man page is misleading. Maybe better wording would
> be:
>
> In the kernel, this is referred to as collect metadata mode.
>
thanks! I will rephrase and submit another version.