netdev - RE: [PATCH net-next v5 0/4] net: fec: fix refclk enable for SMSC LAN8710/20

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Dec 2017 02:21:04 +0000
From:   Andy Duan <fugang.duan@....com>
To:     Richard Leitner <dev@...l1n.net>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "frowand.list@...il.com" <frowand.list@...il.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "geert+renesas@...der.be" <geert+renesas@...der.be>,
        "sergei.shtylyov@...entembedded.com" 
        <sergei.shtylyov@...entembedded.com>,
        "baruch@...s.co.il" <baruch@...s.co.il>,
        "david.wu@...k-chips.com" <david.wu@...k-chips.com>,
        "lukma@...x.de" <lukma@...x.de>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "richard.leitner@...data.com" <richard.leitner@...data.com>
Subject: RE: [PATCH net-next v5 0/4] net: fec: fix refclk enable for SMSC
 LAN8710/20

From: Richard Leitner <dev@...l1n.net> Sent: Monday, December 11, 2017 8:17 PM
>This patch series fixes the use of the SMSC LAN8710/20 with a Freescale ETH
>when the refclk is generated by the FSL.
>
>This patchset depends on the "phylib: Add device reset GPIO support" patch
>submitted by Geert Uytterhoeven/Sergei Shtylyov, which was merged to net-
>next as commit bafbdd527d56 ("phylib: Add device reset GPIO support").
>
>Changes v5:
>	- fix reset delay calculation (max_t instead of min_t)
>
>Changes v4:
>	- simplify dts parsing
>	- simplify reset delay evaluation and execution
>	- fec: ensure to only reset once during fec_enet_open()
>	- remove dependency notes from commit message
>	- add reviews and acks
>
>Changes v3:
>	- use phylib to hard-reset the PHY
>	- implement reset delays in phylib
>	- add new phylib API & flag (PHY_RST_AFTER_CLK_EN) to determine if
>	  a PHY is affected
>
>Changes v2:
>	- simplify and fix fec_reset_phy function to support multiple calls
>	- include: linux: phy: harmonize phy_id{,_mask} type
>	- reset the phy instead of not turning the clock on and off
>	  (which would have caused a power consumption regression)
>
>Richard Leitner (4):
>  phylib: Add device reset delay support
>  phylib: add reset after clk enable support
>  net: phy: smsc: LAN8710/20: add PHY_RST_AFTER_CLK_EN flag
>  net: fec: add phy_reset_after_clk_enable() support
>
> Documentation/devicetree/bindings/net/phy.txt | 10 ++++++++++
> drivers/net/ethernet/freescale/fec_main.c     | 20 ++++++++++++++++++++
> drivers/net/phy/mdio_device.c                 | 13 +++++++++++--
> drivers/net/phy/phy_device.c                  | 24 ++++++++++++++++++++++++
> drivers/net/phy/smsc.c                        |  2 +-
> drivers/of/of_mdio.c                          |  4 ++++
> include/linux/mdio.h                          |  2 ++
> include/linux/phy.h                           |  2 ++
> 8 files changed, 74 insertions(+), 3 deletions(-)
>
>--
>2.11.0

The series look fine better. Thanks.

Acked-by: Fugang Duan <fugang.duan@....com>