netdev - Re: [PATCH net] tcp: refresh tcp_mstamp from timers callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACSApvaJ5Tzw_-zZuDyHY4U5CQMBa6Mi5FrF8PPyWKZhd64XqA@mail.gmail.com>
Date:   Tue, 12 Dec 2017 21:42:48 -0500
From:   Soheil Hassas Yeganeh <soheil.kdev@...il.com>
To:     Neal Cardwell <ncardwell@...gle.com>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Mike Maloney <maloney@...gle.com>
Subject: Re: [PATCH net] tcp: refresh tcp_mstamp from timers callbacks

On Tue, Dec 12, 2017 at 9:26 PM, Neal Cardwell <ncardwell@...gle.com> wrote:
> On Tue, Dec 12, 2017 at 9:22 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
>> From: Eric Dumazet <edumazet@...gle.com>
>>
>> Only the retransmit timer currently refreshes tcp_mstamp
>>
>> We should do the same for delayed acks and keepalives.
>>
>> Even if RFC 7323 does not request it, this is consistent to what linux
>> did in the past, when TS values were based on jiffies.
>>
>> Fixes: 385e20706fac ("tcp: use tp->tcp_mstamp in output path")
>> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>> Cc: Soheil Hassas Yeganeh <soheil@...gle.com>
>> Cc: Mike Maloney <maloney@...gle.com>
>> Cc: Neal Cardwell <ncardwell@...gle.com>
>> ---
>
> Acked-by: Neal Cardwell <ncardwell@...gle.com>
>
> Thanks, Eric!
>
> neal

Acked-by: Soheil Hassas Yeganeh <soheil@...gle.com>

This is a very nice catch! Thank you Eric!