netdev - Re: [BUG] kaweth: a possible sleep-in-atomic bug in kaweth_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1513156889.26281.4.camel@suse.com>
Date:   Wed, 13 Dec 2017 10:21:29 +0100
From:   Oliver Neukum <oneukum@...e.com>
To:     Jia-Ju Bai <baijiaju1990@...il.com>,
        David Miller <davem@...emloft.net>, tklauser@...tanz.ch,
        arvind.yadav.cs@...il.com, edumazet@...gle.com,
        johannes.berg@...el.com
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-usb@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [BUG] kaweth: a possible sleep-in-atomic bug in
 kaweth_start_xmit

Am Mittwoch, den 13.12.2017, 16:57 +0800 schrieb Jia-Ju Bai:
> According to drivers/net/usb/kaweth.c, the driver may sleep under a 
> spinlock.
> The function call path is:
> kaweth_start_xmit (acquire the spinlock)
>    kaweth_async_set_rx_mode
>      kaweth_control
>        kaweth_internal_control_msg
>          usb_start_wait_urb
>            wait_event_timeout --> may sleep
>            usb_kill_urb --> may sleep
> 
> I do not find a good way to fix it, so I only report.
> This possible bug is found by my static analysis tool (DSAC) and checked 
> by my code review.
> 

Hi,

thanks for reporting. I need to get out my old test device.
It will take a few days. The obvious fix would be to set this
filter only on initialization. Unfortunately this needs to
be tested.

	Regards
		Oliver