netdev - Re: [PATCH ipsec-next] xfrm: check for xdo_dev_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c938dafb-e2a8-ff75-4ef3-cbd1ea62f8dc@oracle.com>
Date:   Thu, 14 Dec 2017 08:28:17 -0800
From:   Shannon Nelson <shannon.nelson@...cle.com>
To:     Steffen Klassert <steffen.klassert@...unet.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH ipsec-next] xfrm: check for xdo_dev_state_free

On 12/13/2017 10:20 PM, Steffen Klassert wrote:
> On Mon, Dec 11, 2017 at 12:57:22PM -0800, Shannon Nelson wrote:
>> The current XFRM code assumes that we've implemented the
>> xdo_dev_state_free() callback, even if it is meaningless to the driver.

<snip>

>> +		if (dev->features & NETIF_F_HW_ESP_TX_CSUM) {
>> +			netdev_err(dev, "NETIF_F_HW_ESP_TX_CSUM without NETIF_F_HW_ESP\n");
>> +			return NOTIFY_BAD;
>> +		} else {
>> +			return NOTIFY_DONE;
>> +		}
>> +	}
>> +
>> +	if (!(dev->xfrmdev_ops &&
>> +	      dev->xfrmdev_ops->xdo_dev_state_add &&
>> +	      dev->xfrmdev_ops->xdo_dev_state_delete)) {
>> +		netdev_err(dev, "add or delete function missing from xfrmdev_ops\n");
> 
> Please remove these error printings, this is not relevant for normal
> users.
> 

Okay.

After I posted this I realized this really should be two patches, so 
I'll split this up as well before resending.

sln