netdev - Re: [PATCH CFT] net: phy: micrel: remove unnecessary duplicate interrupt enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 14 Dec 2017 13:21:01 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     rmk+kernel@...linux.org.uk
Cc:     andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH CFT] net: phy: micrel: remove unnecessary duplicate
 interrupt enable

From: Russell King <rmk+kernel@...linux.org.uk>
Date: Tue, 12 Dec 2017 11:02:12 +0000

> Now that we call phy_resume() before enabling interrupts, the workaround
> in micrel is no longer required.
> 
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>
> ---
> This depends on the previous "net: phy: fix resume handling" patch, but
> is not necessary to be a part of it.  Since kszphy_resume() is used for
> PHYs which I don't have, I can't test this, so I decided to keep it
> separate.  Can we get it tested on KSZ8081, KSZ8091 or KSZ9031 PHYs?

Russell, please repost this once someone does some testing.

Yes, I realize it can be difficult to obtain this, but please
do your best.