netdev - Re: [PATCHv2 net-next 03/15] net: sched: sch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Dec 2017 13:52:50 -0500
From:   Alexander Aring <aring@...atatu.com>
To:     Jamal Hadi Salim <jhs@...atatu.com>
Cc:     Cong Wang <xiyou.wangcong@...il.com>,
        Jiří Pírko <jiri@...nulli.us>,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        kernel@...atatu.com, Alexander Aring <aring@...atatu.com>,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCHv2 net-next 03/15] net: sched: sch_api: handle generic
 qdisc errors

Hi,

On Thu, Dec 14, 2017 at 1:38 PM, Alexander Aring <aring@...atatu.com> wrote:
> This patch adds extack support for generic qdisc handling. The extack
> will be set deeper to each called function which is not part of netdev
> core api.
>
> Cc: David Ahern <dsahern@...il.com>
> Signed-off-by: Alexander Aring <aring@...atatu.com>
> ---
>  net/sched/sch_api.c | 159 ++++++++++++++++++++++++++++++++++++----------------
>  1 file changed, 112 insertions(+), 47 deletions(-)
>
> diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
> index b54917f4ad87..3ff59433781b 100644
> --- a/net/sched/sch_api.c
> +++ b/net/sched/sch_api.c
> @@ -449,7 +449,8 @@ static const struct nla_policy stab_policy[TCA_STAB_MAX + 1] = {
>         [TCA_STAB_DATA] = { .type = NLA_BINARY },
>  };
>
> -static struct qdisc_size_table *qdisc_get_stab(struct nlattr *opt)
> +static struct qdisc_size_table *qdisc_get_stab(struct nlattr *opt,
> +                                              struct netlink_ext_ack *extack)
>  {
...
>         sch = qdisc_alloc(dev_queue, ops);
> -       if (IS_ERR(sch)) {
> +       if (IS_ERR(sch))
>                 err = PTR_ERR(sch);
>                 goto err_out2;
> -       }
>

sorry, I detect this now. brackets should still be there. Happens in
some rebase foo stuff v1, didn't contained handling of extack in this
function...

I will send v3.

- Alex