netdev - Re: [PATCH net-next v4 0/5] Introduce NETIF_F_GRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ3xEMg2SMCVfkFq0+x=iAo+E=bgSSNme2tn_b+sNc=wB+Z-Cw@mail.gmail.com>
Date:   Thu, 14 Dec 2017 22:01:25 +0200
From:   Or Gerlitz <gerlitz.or@...il.com>
To:     Michael Chan <michael.chan@...adcom.com>
Cc:     David Miller <davem@...emloft.net>,
        Linux Netdev List <netdev@...r.kernel.org>,
        Andy Gospodarek <andrew.gospodarek@...adcom.com>,
        Gal Pressman <galp@...lanox.com>
Subject: Re: [PATCH net-next v4 0/5] Introduce NETIF_F_GRO_HW

On Thu, Dec 14, 2017 at 8:36 PM, Michael Chan <michael.chan@...adcom.com> wrote:
> On Thu, Dec 14, 2017 at 8:34 AM, Or Gerlitz <gerlitz.or@...il.com> wrote:
>> On Mon, Dec 11, 2017 at 1:41 PM, Michael Chan <michael.chan@...adcom.com> wrote:
>>> Introduce NETIF_F_GRO_HW feature flag and convert drivers that support
>>> hardware GRO to use the new flag.
>>
>> Hi Michael,
>>
>> Could you add more performance motivations/results? looking on your
>> netconf slides [1]
>> I see (much) better CPU utilization (slide 5) -- do you have more
>> numbers to share?
>
> The motivations are the same as LRO:  to achieve higher RX throughput
> and lower CPU utilization.

makes sense, what is the +/- %% improvement in RX throughput you see?

> You can think of it as an improved version of LRO that is stricter and
> provides more information to construct the GRO frame so that it is
> reversible.

sounds good to me