netdev - Re: [PATCH net-next v4 4/5] bnx2x: Use NETIF_F_GRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLinHSRrOvsKheKtvL6d6P67X1DiRG2Bq9Bxv0NrC1U2Msg@mail.gmail.com>
Date:   Wed, 13 Dec 2017 23:59:14 -0800
From:   Michael Chan <michael.chan@...adcom.com>
To:     "Chopra, Manish" <Manish.Chopra@...ium.com>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "andrew.gospodarek@...adcom.com" <andrew.gospodarek@...adcom.com>,
        "Elior, Ariel" <Ariel.Elior@...ium.com>,
        Dept-Eng Everest Linux L2 <Dept-EngEverestLinuxL2@...ium.com>
Subject: Re: [PATCH net-next v4 4/5] bnx2x: Use NETIF_F_GRO_HW.

On Wed, Dec 13, 2017 at 11:46 PM, Chopra, Manish
<Manish.Chopra@...ium.com> wrote:

>
> 2). In bnx2x_fix_features() we used to do before these changes -
>
>         /* TPA requires Rx CSUM offloading */
>         if (!(features & NETIF_F_RXCSUM)) {
>                 features &= ~NETIF_F_LRO;
>                 features &= ~NETIF_F_GRO;
>         }
>
> I think we should not turn off SW gro here, we should turn off HW gro here now ?

OK.  I will remove GRO.

GRO_HW will be turned off by netdev_fix_features() when RXCSUM is not on.