netdev - Re: [PATCH net 2/3] net: sched: Move to new offload indication in RED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171214140723.GH1926@nanopsycho>
Date:   Thu, 14 Dec 2017 15:07:23 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Yuval Mintz <yuvalm@...lanox.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, mlxsw@...lanox.com
Subject: Re: [PATCH net 2/3] net: sched: Move to new offload indication in RED

Thu, Dec 14, 2017 at 02:54:30PM CET, yuvalm@...lanox.com wrote:
>Let RED utilize the new internal flag, TCQ_F_OFFLOADED,
>to mark a given qdisc as offloaded instead of using a dedicated
>indication.
>
>Also, change internal logic into looking at said flag when possible.
>
>Fixes: 602f3baf2218 ("net_sch: red: Add offload ability to RED qdisc")
>Signed-off-by: Yuval Mintz <yuvalm@...lanox.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>

Note that it would be good to add red offload presence in drivers
(mlxsw) and forbid to disable tc offload feature in that case.