netdev - Re: [PATCH] net: phy: marvell: enable a errata for 88E1145

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171215.104704.651511100967508376.davem@davemloft.net>
Date:   Fri, 15 Dec 2017 10:47:04 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     qiang.zhao@....com
Cc:     andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: phy: marvell: enable a errata for 88E1145

From: Zhao Qiang <qiang.zhao@....com>
Date: Fri, 15 Dec 2017 14:13:32 +0800

> The patch below
> commit f2899788353c ("net: phy: marvell: Limit errata to 88m1101")
> limit a errata's scope to 88E1101.
> However, 88E1145 also need this errata, set config_aneg to
> m88e1101_config_aneg for 88E1145
> 
> Signed-off-by: Zhao Qiang <qiang.zhao@....com>

The proper way to say that a patch fixes a particular commit it to
reference it in a "Fixes: " tag, like this:

====================
Fixes: f2899788353c ("net: phy: marvell: Limit errata to 88m1101")
Signed-off-by: Zhao Qiang <qiang.zhao@....com>
====================

And then you don't need to reference it explicitly in your commit
message, you can just instead say:

	Limit 88m1101 autoneg errata to 88E1145 as well.

Please fix up your submission like this and resubmit.

Thank you.