netdev - Re: [PATCH net] sock: free skb in skb_complete_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171215.113141.107338195199221393.davem@davemloft.net>
Date:   Fri, 15 Dec 2017 11:31:41 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     willemdebruijn.kernel@...il.com
Cc:     netdev@...r.kernel.org, richardcochran@...il.com,
        willemb@...gle.com
Subject: Re: [PATCH net] sock: free skb in skb_complete_tx_timestamp on
 error

From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Date: Wed, 13 Dec 2017 14:41:06 -0500

> From: Willem de Bruijn <willemb@...gle.com>
> 
> skb_complete_tx_timestamp must ingest the skb it is passed. Call
> kfree_skb if the skb cannot be enqueued.
> 
> Fixes: b245be1f4db1 ("net-timestamp: no-payload only sysctl")
> Fixes: 9ac25fc06375 ("net: fix socket refcounting in skb_complete_tx_timestamp()")
> Reported-by: Richard Cochran <richardcochran@...il.com>
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Applied and queued up for -stable.