netdev - Re: [PATCH net-next] net: phy: broadcom: Add entry for 5395 switch PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B7BA7EC7-C19E-46C8-8B7D-D4071ED9180F@gmail.com>
Date:   Fri, 15 Dec 2017 12:08:21 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     netdev@...r.kernel.org, cphealy@...il.com
Subject: Re: [PATCH net-next] net: phy: broadcom: Add entry for 5395 switch PHYs

On December 15, 2017 1:10:44 AM PST, Andrew Lunn <andrew@...n.ch> wrote:
>On Thu, Dec 14, 2017 at 05:48:16PM -0800, Florian Fainelli wrote:
>> Add an entry for the builtin PHYs present in the Broadcom BCM5395
>switch. This
>> allows us to retrieve the PHY statistics among other things.
>
>>  static struct phy_driver broadcom_drivers[] = {
>>  {
>>  	.phy_id		= PHY_ID_BCM5411,
>> @@ -679,6 +710,16 @@ static struct phy_driver broadcom_drivers[] = {
>>  	.config_init	= brcm_fet_config_init,
>>  	.ack_interrupt	= brcm_fet_ack_interrupt,
>>  	.config_intr	= brcm_fet_config_intr,
>> +}, {
>> +	.phy_id		= PHY_ID_BCM5395,
>> +	.phy_id_mask	= 0xfffffff0,
>> +	.name		= "Broadcom BCM5395",
>> +	.flags		= PHY_IS_INTERNAL,
>> +	.features	= PHY_GBIT_FEATURES,
>> +	.get_sset_count	= bcm_phy_get_sset_count,
>> +	.get_strings	= bcm_phy_get_strings,
>> +	.get_stats	= bcm53xx_phy_get_stats,
>> +	.probe		= bcm53xx_phy_probe,
>>  } };
>
>Hi Florian
>
>Is this the only PHY supported by this driver which has statistics?

I need to cross check with the various data sheets to be sure, but it is quite likely that all Gigabit capable PHYs listed above would also support the same statistics. In any case, this would be a follow on patch to this one.

Thanks!
>
>   Andrew

Hi Andrew,
-- 
Florian