netdev - Re: [patch net 1/2] net: sched: fix clsact init error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171215.154449.1971297738166148632.davem@davemloft.net>
Date:   Fri, 15 Dec 2017 15:44:49 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        mlxsw@...lanox.com, daniel@...earbox.net
Subject: Re: [patch net 1/2] net: sched: fix clsact init error path

From: Jiri Pirko <jiri@...nulli.us>
Date: Fri, 15 Dec 2017 12:40:12 +0100

> From: Jiri Pirko <jiri@...lanox.com>
> 
> Since in qdisc_create, the destroy op is called when init fails, we
> don't do cleanup in init and leave it up to destroy.
> This fixes use-after-free when trying to put already freed block.
> 
> Fixes: 6e40cf2d4dee ("net: sched: use extended variants of block_get/put in ingress and clsact qdiscs")
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Applied.