netdev - Re: [patch iproute2] tc: fix command "tc actions del" hang issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Dec 2017 21:16:58 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Chris Mi <chrism@...lanox.com>
Cc:     netdev@...r.kernel.org, jiri@...nulli.us
Subject: Re: [patch iproute2] tc: fix command "tc actions del" hang issue

On Thu, 14 Dec 2017 18:09:00 +0900
Chris Mi <chrism@...lanox.com> wrote:

> If command is RTM_DELACTION, a non-NULL pointer is passed to rtnl_talk().
> Then flag NLM_F_ACK is not set on n->nlmsg_flags and netlink_ack() will
> not be called. Command tc will wait for the reply for ever.
> 
> Fixes: 86bf43c7c2fd ("lib/libnetlink: update rtnl_talk to support malloc
> buff at run time")
> Signed-off-by: Chris Mi <chrism@...lanox.com>
> Reviewed-by: Jiri Pirko <jiri@...lanox.com>

Thanks for fixing this.
Applied, but please don't linewrap the fixes tag.