lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 Dec 2017 10:09:57 +0100 From: Jiri Pirko <jiri@...nulli.us> To: Jakub Kicinski <jakub.kicinski@...ronome.com> Cc: netdev@...r.kernel.org, davem@...emloft.net, jhs@...atatu.com, xiyou.wangcong@...il.com, mlxsw@...lanox.com, andrew@...n.ch, vivien.didelot@...oirfairelinux.com, f.fainelli@...il.com, michael.chan@...adcom.com, ganeshgr@...lsio.com, saeedm@...lanox.com, matanb@...lanox.com, leonro@...lanox.com, idosch@...lanox.com, simon.horman@...ronome.com, pieter.jansenvanvuuren@...ronome.com, john.hurley@...ronome.com, alexander.h.duyck@...el.com, ogerlitz@...lanox.com, john.fastabend@...il.com, daniel@...earbox.net Subject: Re: [patch net-next v3 05/10] net: sched: keep track of offloaded filters and check tc offload feature Thu, Dec 14, 2017 at 08:22:43PM CET, jakub.kicinski@...ronome.com wrote: >On Wed, 13 Dec 2017 16:10:33 +0100, Jiri Pirko wrote: >> diff --git a/net/sched/cls_bpf.c b/net/sched/cls_bpf.c >> index 69d7e9a..9cf61e7 100644 >> --- a/net/sched/cls_bpf.c >> +++ b/net/sched/cls_bpf.c >> @@ -170,8 +170,10 @@ static int cls_bpf_offload_cmd(struct tcf_proto *tp, struct cls_bpf_prog *prog, >> cls_bpf_offload_cmd(tp, prog, TC_CLSBPF_DESTROY); >> return err; >> } else if (err > 0) { >> - prog->gen_flags |= TCA_CLS_FLAGS_IN_HW; >> + tcf_block_offload_inc(block, &prog->gen_flags); >> } >> + } else { >> + tcf_block_offload_dec(block, &prog->gen_flags); >> } >> >> if (addorrep && skip_sw && !(prog->gen_flags & TCA_CLS_FLAGS_IN_HW)) > >The in_hw reporting also seems broken. > >tools/testing/selftests/bpf/test_offload.py catches this. Will check it. Thanks!
Powered by blists - more mailing lists