lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <201712161349.md8nXXWa%fengguang.wu@intel.com>
Date:   Sat, 16 Dec 2017 13:49:15 +0800
From:   kbuild test robot <fengguang.wu@...el.com>
To:     Salil Mehta <salil.mehta@...wei.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        lipeng <lipeng321@...wei.com>
Subject: [net-next:master 353/390]
 drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c:1290:37-38:
 Unneeded semicolon

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head:   28dc4c8f4557d82e9be020e85e2362239270e704
commit: e963cb789a29b890678b58ef7da5d7c497510b7e [353/390] net: hns3: Add HNS3 VF driver to kernel build framework


coccinelle warnings: (new ones prefixed by >>)

>> drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c:1290:37-38: Unneeded semicolon

vim +1290 drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c

e2cb1dec Salil Mehta 2017-12-14  1262  
e2cb1dec Salil Mehta 2017-12-14  1263  static int hclgevf_pci_init(struct hclgevf_dev *hdev)
e2cb1dec Salil Mehta 2017-12-14  1264  {
e2cb1dec Salil Mehta 2017-12-14  1265  	struct pci_dev *pdev = hdev->pdev;
e2cb1dec Salil Mehta 2017-12-14  1266  	struct hclgevf_hw *hw;
e2cb1dec Salil Mehta 2017-12-14  1267  	int ret;
e2cb1dec Salil Mehta 2017-12-14  1268  
e2cb1dec Salil Mehta 2017-12-14  1269  	ret = pci_enable_device(pdev);
e2cb1dec Salil Mehta 2017-12-14  1270  	if (ret) {
e2cb1dec Salil Mehta 2017-12-14  1271  		dev_err(&pdev->dev, "failed to enable PCI device\n");
e2cb1dec Salil Mehta 2017-12-14  1272  		goto err_no_drvdata;
e2cb1dec Salil Mehta 2017-12-14  1273  	}
e2cb1dec Salil Mehta 2017-12-14  1274  
e2cb1dec Salil Mehta 2017-12-14  1275  	ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
e2cb1dec Salil Mehta 2017-12-14  1276  	if (ret) {
e2cb1dec Salil Mehta 2017-12-14  1277  		dev_err(&pdev->dev, "can't set consistent PCI DMA, exiting");
e2cb1dec Salil Mehta 2017-12-14  1278  		goto err_disable_device;
e2cb1dec Salil Mehta 2017-12-14  1279  	}
e2cb1dec Salil Mehta 2017-12-14  1280  
e2cb1dec Salil Mehta 2017-12-14  1281  	ret = pci_request_regions(pdev, HCLGEVF_DRIVER_NAME);
e2cb1dec Salil Mehta 2017-12-14  1282  	if (ret) {
e2cb1dec Salil Mehta 2017-12-14  1283  		dev_err(&pdev->dev, "PCI request regions failed %d\n", ret);
e2cb1dec Salil Mehta 2017-12-14  1284  		goto err_disable_device;
e2cb1dec Salil Mehta 2017-12-14  1285  	}
e2cb1dec Salil Mehta 2017-12-14  1286  
e2cb1dec Salil Mehta 2017-12-14  1287  	pci_set_master(pdev);
e2cb1dec Salil Mehta 2017-12-14  1288  	hw = &hdev->hw;
e2cb1dec Salil Mehta 2017-12-14  1289  	hw->hdev = hdev;
e2cb1dec Salil Mehta 2017-12-14 @1290  	hw->io_base = pci_iomap(pdev, 2, 0);;
e2cb1dec Salil Mehta 2017-12-14  1291  	if (!hw->io_base) {
e2cb1dec Salil Mehta 2017-12-14  1292  		dev_err(&pdev->dev, "can't map configuration register space\n");
e2cb1dec Salil Mehta 2017-12-14  1293  		ret = -ENOMEM;
e2cb1dec Salil Mehta 2017-12-14  1294  		goto err_clr_master;
e2cb1dec Salil Mehta 2017-12-14  1295  	}
e2cb1dec Salil Mehta 2017-12-14  1296  
e2cb1dec Salil Mehta 2017-12-14  1297  	return 0;
e2cb1dec Salil Mehta 2017-12-14  1298  
e2cb1dec Salil Mehta 2017-12-14  1299  err_clr_master:
e2cb1dec Salil Mehta 2017-12-14  1300  	pci_clear_master(pdev);
e2cb1dec Salil Mehta 2017-12-14  1301  	pci_release_regions(pdev);
e2cb1dec Salil Mehta 2017-12-14  1302  err_disable_device:
e2cb1dec Salil Mehta 2017-12-14  1303  	pci_disable_device(pdev);
e2cb1dec Salil Mehta 2017-12-14  1304  err_no_drvdata:
e2cb1dec Salil Mehta 2017-12-14  1305  	pci_set_drvdata(pdev, NULL);
e2cb1dec Salil Mehta 2017-12-14  1306  	return ret;
e2cb1dec Salil Mehta 2017-12-14  1307  }
e2cb1dec Salil Mehta 2017-12-14  1308  

:::::: The code at line 1290 was first introduced by commit
:::::: e2cb1dec9779ba2d89302a653eb0abaeb8682196 net: hns3: Add HNS3 VF HCL(Hardware Compatibility Layer) Support

:::::: TO: Salil Mehta <salil.mehta@...wei.com>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ