netdev - Re: [PATCH iproute2 0/3] Improve tunnel local/remote endpoint params and gre link attribute handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171216101008.4b32dcd8@xeon-e3>
Date:   Sat, 16 Dec 2017 10:10:08 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Serhey Popovych <serhe.popovych@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 0/3] Improve tunnel local/remote endpoint
 params and gre link attribute handling

On Wed, 13 Dec 2017 21:35:59 +0200
Serhey Popovych <serhe.popovych@...il.com> wrote:

> In this series following problems addressed:
> 
>   1) Size of IFLA_GRE_LINK attribute is 32 bits long in , not 8 bit.
> 
>   2) Use get_addr() instead of get_prefix() to parse local/remote
>      tunnel endpoints as IPADDR, not PREFIX as per ip-link(8).
> 
>   3) No need to check if local/remote endpoints are zero (e.g. INADDR_ANY):
>      it is fully legal value, accepted by the kernel.
> 
> See individual patch description message for details.
> 
> Thanks,
> Serhii
> 
> Serhey Popovych (3):
>   ip/tunnel: Unify setup and accept zero address for local/remote
>     endpoints
>   ip/tunnel: Use get_addr() instead of get_prefix() for local/remote
>     endpoints
>   ip: gre: fix IFLA_GRE_LINK attribute sizing
> 
>  ip/ip6tunnel.c   |    8 ++------
>  ip/iptunnel.c    |   10 ++--------
>  ip/link_gre.c    |    8 +++-----
>  ip/link_gre6.c   |    8 ++------
>  ip/link_ip6tnl.c |   12 ++++--------
>  ip/link_iptnl.c  |   10 ++--------
>  ip/link_vti.c    |   14 ++------------
>  ip/link_vti6.c   |   26 ++++++++------------------
>  8 files changed, 25 insertions(+), 71 deletions(-)
> 

Looks good, applied