netdev - Re: [PATCH v2 ipsec-next 3/3] xfrm: wrap xfrmdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201712170317.SLwe6dgx%fengguang.wu@intel.com>
Date:   Sun, 17 Dec 2017 03:12:34 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Shannon Nelson <shannon.nelson@...cle.com>
Cc:     kbuild-all@...org, steffen.klassert@...unet.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2 ipsec-next 3/3] xfrm: wrap xfrmdev_ops with offload
 config

Hi Shannon,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on ipsec-next/master]

url:    https://github.com/0day-ci/linux/commits/Shannon-Nelson/xfrm-check-for-xdo_dev_state_free/20171217-022754
base:   https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next.git master
config: x86_64-randconfig-x014-201751 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   net/xfrm/xfrm_device.c: In function 'xfrm_dev_feat_change':
>> net/xfrm/xfrm_device.c:172:48: error: 'struct net_device' has no member named 'xfrmdev_ops'; did you mean 'l3mdev_ops'?
     if ((dev->features & NETIF_F_HW_ESP) && !dev->xfrmdev_ops)
                                                   ^~~~~~~~~~~
                                                   l3mdev_ops
   net/xfrm/xfrm_device.c:175:8: error: 'struct net_device' has no member named 'xfrmdev_ops'; did you mean 'l3mdev_ops'?
      dev->xfrmdev_ops = NULL;
           ^~~~~~~~~~~
           l3mdev_ops

vim +172 net/xfrm/xfrm_device.c

d77e38e6 Steffen Klassert 2017-04-14  169  
d77e38e6 Steffen Klassert 2017-04-14  170  static int xfrm_dev_feat_change(struct net_device *dev)
d77e38e6 Steffen Klassert 2017-04-14  171  {
d77e38e6 Steffen Klassert 2017-04-14 @172  	if ((dev->features & NETIF_F_HW_ESP) && !dev->xfrmdev_ops)
d77e38e6 Steffen Klassert 2017-04-14  173  		return NOTIFY_BAD;
d77e38e6 Steffen Klassert 2017-04-14  174  	else if (!(dev->features & NETIF_F_HW_ESP))
d77e38e6 Steffen Klassert 2017-04-14  175  		dev->xfrmdev_ops = NULL;
d77e38e6 Steffen Klassert 2017-04-14  176  
d77e38e6 Steffen Klassert 2017-04-14  177  	if ((dev->features & NETIF_F_HW_ESP_TX_CSUM) &&
d77e38e6 Steffen Klassert 2017-04-14  178  	    !(dev->features & NETIF_F_HW_ESP))
d77e38e6 Steffen Klassert 2017-04-14  179  		return NOTIFY_BAD;
d77e38e6 Steffen Klassert 2017-04-14  180  
d77e38e6 Steffen Klassert 2017-04-14  181  	return NOTIFY_DONE;
d77e38e6 Steffen Klassert 2017-04-14  182  }
d77e38e6 Steffen Klassert 2017-04-14  183  

:::::: The code at line 172 was first introduced by commit
:::::: d77e38e612a017480157fe6d2c1422f42cb5b7e3 xfrm: Add an IPsec hardware offloading API

:::::: TO: Steffen Klassert <steffen.klassert@...unet.com>
:::::: CC: Steffen Klassert <steffen.klassert@...unet.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (34262 bytes)